To connect to your Mac, Windows users need the network address for your Mac, and a user name and password to use to log in to your Mac.
To find your Mac computer’s network address, choose Apple menu
in the sidebar, click Sharing on the right, then click the Info button next to File Sharing. (You may need to scroll down.) The address appears below the “File Sharing: On” indicator, and looks similar to smb://17.212.167.33/ or smb://computername.example.com.Create an account on your Mac for each Windows user. To create accounts, choose Apple menu> System Settings, then click Users & Groups
in the sidebar. (You may need to scroll down.) See Add a user or group.If you want to use an account that existed before you installed the latest version of macOS, you may need to reset the password for the account in Users & Groups settings.
in the sidebar, click Sharing on the right, then click the Info button 
next to File Sharing. (You may need to scroll down.) The address appears below the “File Sharing: On” indicator, and looks similar to smb://17.212.167.33/ or smb://computername.example.com.
in the sidebar. (You may need to scroll down.) See Because the passwords of user accounts used for Windows sharing may be stored in a less secure manner, turn off the account when it’s not being used. Before you turn off Windows sharing, turn off all the accounts you enabled. Otherwise, the passwords are still stored less securely.
